Merge pull request #35 from zbigniewKurasLM/product-page-template-imp…

…rovements

Issue#27 - Do not show attachment tab on product page with no attachments

CHANGELOG.md

@@ -35,4 +35,7 @@
 * compatibility fix for magento CE 2.3.5
 
 ### 1.3.4 ###
-* fix for return type fix for configuration provider
+* fix for return type fix for configuration provider
+
+### 1.3.5 ###
+* do not show attachment tab on product page with no attachments

composer.json

@@ -9,7 +9,7 @@
         "magento/module-ui": "*"
     },
     "type": "magento2-module",
-    "version": "1.3.4",
+    "version": "1.3.5",
     "license": [
         "MIT"
     ],

etc/module.xml

@@ -7,7 +7,7 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="LizardMedia_ProductAttachment" setup_version="1.3.4">
+    <module name="LizardMedia_ProductAttachment" setup_version="1.3.5">
         <sequence>
             <module name="Magento_Downloadable"/>
             <module name="Magento_Catalog"/>

view/frontend/templates/product/view/attachment-tab.phtml

@@ -1,8 +1,7 @@
 <?php /** @var $block LizardMedia\ProductAttachment\Block\Product\AttachmentTab */ ?>
-<div id="product-attachments-container" data-role="product-attachments"></div>
-
 <?php $attachments = $block->getAttachments() ?>
 <?php if (count($attachments)) : ?>
+    <div id="product-attachments-container" data-role="product-attachments"></div>
     <div class="table-wrapper attachments">
         <table class="data table">
             <thead>
@@ -26,9 +25,4 @@
             </tbody>
         </table>
     </div>
-
-<?php else : ?>
-    <div class="message info empty">
-        <span><?= /* @escapeNotVerified */ __('This products does not contain any attachments.') ?></span>
-    </div>
-<?php endif; ?>
+<?php endif; ?>