installer/installer.go: Avoid extra memory allocations

livingsilver94 · Nov 5, 2023 · 2a5649d · 2a5649d
1 parent a2fbd2a
commit 2a5649d
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/installer/installer.go b/installer/installer.go
@@ -37,11 +37,12 @@ func (inst *Installer) Install(srv *service.Service) error {
 		return err
 	}
 	for level := depGraph.Depth() - 1; level >= 0; level-- {
-		for _, dep := range depGraph.Level(level).Slice() {
-			err := inst.installSingle(dep)
-			if err != nil {
-				return err
-			}
+		depGraph.Level(level).ForEach(func(dep *service.Service) bool {
+			err = inst.installSingle(dep)
+			return err == nil
+		})
+		if err != nil {
+			return err
 		}
 	}
 	return inst.installSingle(srv)