Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Updated target application drawer to contain labels #4078

Merged
merged 1 commit into from
Jul 6, 2023
Merged

fix: Updated target application drawer to contain labels #4078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion chaoscenter/web/src/routes/RouteDestinations.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@ export function RoutesWithAuthentication(): React.ReactElement {
if (!token || !isUserAuthenticated()) {
forceLogout();
}
}, [forceLogout, token]);
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [token]);

return (
<Switch>
Expand Down
2 changes: 1 addition & 1 deletion chaoscenter/web/src/strings/strings.en.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ genericResourceNotFoundError: >-
has been deleted.
gitConnection: Repository Connection
goBack: Go back to previous page
goChaosHome: Go to Chaos Home
goChaosHome: Go to Home
greatJob: Great Job
group: Group
healthy: Healthy
Expand Down
26 changes: 6 additions & 20 deletions ...c/views/ExperimentCreationFaultConfiguration/Tabs/TargetApplication/TargetApplication.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@ export default function TargetApplicationTab({
<Container padding={{ left: 'xxlarge', right: 'xxlarge', top: 'xlarge', bottom: 'xlarge' }}>
<Text font={{ variation: FontVariation.BODY }}>{getString('provideTargetApplicationDetails')}</Text>
{engineCR?.spec?.appinfo?.appkind !== undefined && (
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
<Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appKind')}</Text>
<DropDown
width={'50%'}
placeholder={getString('selectAppKind')}
Expand All @@ -72,29 +73,13 @@ export default function TargetApplicationTab({
setFaultData(faultData => {
if (faultData?.faultName) return { ...faultData, engineCR: faultData?.engineCR };
});
// gvrData.map(data => {
// if (data.resource === selectedItem.label) {
// getKubeObjectLazyQueryFunction({
// variables: {
// kubeObjectRequest: {
// infraID: infrastructureID ?? '',
// requestID: uuid(),
// kubeObjRequest: {
// group: data.group,
// version: data.version,
// resource: `${data.resource}s`
// }
// }
// }
// });
// }
// });
}}
/>
</Layout.Vertical>
)}
{engineCR?.spec?.appinfo?.appns !== undefined && (
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
<Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appNameSpace')}</Text>
<DropDown
width={'50%'}
placeholder={getString('selectAppNamespace')}
Expand All @@ -112,7 +97,8 @@ export default function TargetApplicationTab({
</Layout.Vertical>
)}
{engineCR?.spec?.appinfo?.applabel !== undefined && (
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }}>
<Layout.Vertical margin={{ top: 'medium', bottom: 'medium' }} spacing="xsmall">
<Text font={{ variation: FontVariation.FORM_LABEL }}>{getString('appLabel')}</Text>
<DropDown
width={'50%'}
placeholder={getString('selectAppLabel')}
Expand Down
Loading