Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ChaosCenter] chore : update function parameter for passing test cases #4016

Merged
merged 2 commits into from
Jun 21, 2023

Conversation

namkyu1999
Copy link
Member

@namkyu1999 namkyu1999 commented Jun 20, 2023

Proposed changes

Update function parameter for passing unit test cases.

releated pr. #4009

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

Special notes for your reviewer:

@namkyu1999 namkyu1999 added kind/unit-test READY-FOR-REVIEW go Pull requests that update Go code labels Jun 20, 2023
@namkyu1999 namkyu1999 requested a review from amityt June 20, 2023 11:22
@namkyu1999 namkyu1999 self-assigned this Jun 20, 2023
@imrajdas imrajdas merged commit 30cbd7c into litmuschaos:master Jun 21, 2023
SohamRatnaparkhi pushed a commit to SohamRatnaparkhi/litmus that referenced this pull request Jun 30, 2023
SohamRatnaparkhi pushed a commit to SohamRatnaparkhi/litmus that referenced this pull request Jun 30, 2023
Signed-off-by: namkyu1999 <[email protected]>
Co-authored-by: Amit Kumar Das <[email protected]>
Signed-off-by: SohamRatnaparkhi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code kind/unit-test READY-FOR-REVIEW
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants