[ChaosCenter]: Add unit tests to rest_handlers and authorization package in GraphQL server #3980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: namkyu1999 <[email protected]>
Signed-off-by: namkyu1999 <[email protected]>
namkyu1999
added
kind/unit-test
LFX-MENTORSHIP
S-ayanide
approved these changes
May 19, 2023
amityt
approved these changes
May 19, 2023
Comment on lines
21
to
26
| if err != nil { | ||
| log.Error(err) | ||
| utils.WriteHeaders(&c.Writer, http.StatusBadRequest) | ||
| return | ||
| } else { | ||
| utils.WriteHeaders(&c.Writer, http.StatusOK) | ||
| c.Writer.Write(versionByte) | ||
| } |
There was a problem hiding this comment.
In case of err condition we will need to return with the badRequest status code. Might need to add the return statement in err case
Signed-off-by: namkyu1999 <[email protected]>
SohamRatnaparkhi
pushed a commit
to SohamRatnaparkhi/litmus
that referenced
this pull request
Jun 30, 2023
…age in GraphQL server (litmuschaos#3980) * feat: add unit tests to rest_handlers Signed-off-by: namkyu1999 <[email protected]> * feat: add unit tests to authorization package Signed-off-by: namkyu1999 <[email protected]> * fix: chore Signed-off-by: namkyu1999 <[email protected]> --------- Signed-off-by: namkyu1999 <[email protected]> Signed-off-by: SohamRatnaparkhi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add unit tests to rest_handlers and authorization package
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
[LFX-23Q1]: Improve code quality and add unit tests of chaos center components. #3892
Special notes for your reviewer: