P 993 improve enclaveidentifier managing mechanism #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tifier can register enclave.
Co-authored-by: BillyWooo <[email protected]>
BillyWooo
added
the
C1-noteworthy
BillyWooo
requested review from
kziemianek,
Kailai-Wang,
felixfaisal and
wangminqi
…dentifier-managing-mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title, this PR moves EnclaveIdentifier under root/admin control.
So in production env, only Root/Admin can update the whitelist of EnclaveIdentifier. And only the whitelisted EnclaveIdentifier can register enclaves.
This is a noteworthy change for deployment.
Besides the feature implementation, there are some path fix (originally coming from folder structure change).