[DAT-18790] added defaultValue snapshotting #192
Conversation
|
Should work for most cases except: |
| Column column = (Column) super.snapshotObject(example, snapshot); | ||
| //These two are used too often, avoiding them? otherwise there would be too much DB calls | ||
| if (!column.getRelation().getName().equalsIgnoreCase("databasechangelog") | ||
| && !column.getRelation().getName().equalsIgnoreCase("databasechangeloglock")) { |
There was a problem hiding this comment.
Even with skipping DBCL and DBCLL we are making additional call for every column. We have info for all columns in show create table.
column.getRelation() has all the columns, so we can iterate over them and add defaultValue information for all columns at once
There was a problem hiding this comment.
@SvampX as discussed, maybe DatabaseSnapshot.snapshotScratchPad could be useful to cache this information between executions.
There was a problem hiding this comment.
Moved show create table call to the Table snapshot generator. Storing create table statement in the snapshotScratchPad suggested by @filipelautert with a show create table query as key. I believe such keys should be unique within a database as the query has full table name with catalog and schema.
| if (example instanceof Column) { | ||
| Column column = (Column) super.snapshotObject(example, snapshot); | ||
| //These two are used too often, avoiding them? otherwise there would be too much DB calls | ||
| if (!column.getRelation().getName().equalsIgnoreCase("databasechangelog") |
There was a problem hiding this comment.
tracking tables can have custom names.
better to use database.getDatabaseChangeLogTableName() and database.getDatabaseChangeLogLockTableName()
| Column column = (Column) super.snapshotObject(example, snapshot); | ||
| //These two are used too often, avoiding them? otherwise there would be too much DB calls | ||
| if (!column.getRelation().getName().equalsIgnoreCase("databasechangelog") | ||
| && !column.getRelation().getName().equalsIgnoreCase("databasechangeloglock")) { |
There was a problem hiding this comment.
@SvampX as discussed, maybe DatabaseSnapshot.snapshotScratchPad could be useful to cache this information between executions.
… one per table for column default values. updated test
|
No description provided.