Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove bitcoin cash #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove bitcoin cash #94

wants to merge 1 commit into from

Conversation

kraikov
Copy link
Collaborator

@kraikov kraikov commented Jul 4, 2022

The existence of BCH in the ChainId removes the possibility for proper typings of https://github.com/liquality/wallet-core/blob/master/src/utils/networks.ts#L12

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 4, 2022
@trafico-bot trafico-bot bot added the 🌟 Needs more Approvals Pull Request needs more approvals label Jul 4, 2022
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet 🌟 Needs more Approvals Pull Request needs more approvals labels Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✅ Approved Pull Request has been approved and can be merged size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants