feat: Create film extension #60
Conversation
| } | ||
| ], | ||
| "definitions": { | ||
| "stac_extensions": { |
There was a problem hiding this comment.
This shouldn't be necessary, as done in #58. Basically, if we're validating against this schema then the file contains a reference to this extension, so it's tautological to validate that we're referencing the extension.
There was a problem hiding this comment.
Nice, I thought that looked weird.
There was a problem hiding this comment.
I disagree with this, I also believe #58 should not have been merged. We need to have wider review of sweeping changes before merging things..
By not having the schema referenced in the extensions you could validate a random stac file against this schema and it would be considered "valid" even though it is invalid as stac_extension was not referenced.
All of the STAC spec extensions I looked at have this reference, I do not think we should be deviating from their standard.
eg https://github.com/stac-extensions/raster/blob/main/json-schema/schema.json#L72
There was a problem hiding this comment.
Why would you validate a file against a schema which is not referenced within that file?
There was a problem hiding this comment.
I think the default thing we should do when concern is raised over a merged PR (especially one that is yet to be released) is to revert and discuss.
There was a problem hiding this comment.
The current example of a valid collection.json on the linz extension doesn't reference the quality extension in stac_extensions. Should it? Would that have been picked up if the schema.json for the linz extension contained this check?
There was a problem hiding this comment.
It doesn't because it doesn't need to, and therefore shouldn't, as explained upstream. Having to list nested extensions is pointless overhead.
There was a problem hiding this comment.
Why does it list the version extension?
There was a problem hiding this comment.
Because, like the template repo, the version extension requires us to reference it in every STAC file even though it's referenced from the LINZ extension. This is exactly the thing I'm hoping to avoid.
ref: eb3d494 (commit being reverted) discussion: #60 (comment) upstream issue: stac-extensions/template#10
ref: eb3d494 (commit being reverted) discussion: #60 (comment) upstream issue: stac-extensions/template#10
Add the
filmSTAC Extension, made up of a explanatory README, JSON Schema, examples and non-examples.