Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Sort style config files by prettier json sort plugin. #816

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

Wentao-Kuang
Copy link
Contributor

@Wentao-Kuang Wentao-Kuang commented Nov 6, 2023

Motivation

Style config might have different order in layers when export from maputinik, this makes use hard to review the changes.

Modification

We using prettier json sort plughin to sort all the keys in the style config json files.

Checklist

  • Tests updated
  • Docs updated
  • Issue linked in Title

@Wentao-Kuang Wentao-Kuang marked this pull request as ready for review November 6, 2023 02:22
@Wentao-Kuang Wentao-Kuang requested a review from a team as a code owner November 6, 2023 02:22
@Wentao-Kuang Wentao-Kuang changed the title ci: Sort all config files by prettier json sort plugin. ci: Sort style config files by prettier json sort plugin. Nov 6, 2023
@blacha blacha added this pull request to the merge queue Nov 8, 2023
Merged via the queue into master with commit 01faaef Nov 8, 2023
4 checks passed
@blacha blacha deleted the feat/sort-styles branch November 8, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants