Add support for Dial status LEDs #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whot
force-pushed
the
wip/dial-leds
branch
2 times, most recently
from
77e3e60
to
e2c25a3
Compare
|
cc @Joshua-Dickens for an extra pair of eyeballs :) |
This switches the config to a dict first so we can easily merge it, then we can set up the ConfigParser from our merged dict.
Fixes: b6b82e4 ("Add support for relative dials (linuxwacom#665)")
The implementation looked like this returns an enum value but it doesn't, the returned value is the numerical index of the LED group (typically 0 and 1 for Ring/Ring2 but also 0 and 1 for Strip/Strip2 since we don't have devices with combined features). Let's change the fallback to -1 too instead of the enum - same value but it makes the code more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libinput at least uses the status leds for grouping: our data file says
there's a status led for the ring and the toggle button for the ring is
B, and button are at position P. libinput then uses the fact that there
are two status LEDs to create two groups and matches the buttons
with the position of the mode toggle button (i.e. if button B is in
position P, all buttons in the same position P must belong to the same
mode group).
This requires that the status led for dials exists, so let's add them.
Fixes: b6b82e4 ("Add support for relative dials (#665)")