Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for xp-pen artist 10s table #625

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

hooger
Copy link
Contributor

@hooger hooger commented Jan 14, 2024

I have som trouble with this descriptor, please help me with it.

  • I had to use the string that is returned by libinput list-devices for kwin to recognize the descriptor. However, this is quite weird as the tablet is an XP-Pen Artist 10s, and it is not obvious what an UGEE device is. That would be nice to overwrite, yet the ModelName key has made no difference. Am I doing something wrong, or it is a problem with kwin/ksystem settings?
  • In the example table file there is something about a system identifier generated by wacom-hid-descriptor. Howevert, that project seems to be about devices that are drawing computers, while this device is an external, usb connected drawing tablet. Is it alright that I omitted these comment lines or should I extend the .table file somehow?

@whot
Copy link
Member

whot commented Jan 15, 2024

is not obvious what an UGEE device is

UGEE is afaik the parent company of XP-Pen, so some tablets get rebranded, others get rebranded by sticking them in a XP Pen box without changing the firmware to remove the UGEE references.

It's fine to list the Name as what it says on the box and have the DeviceMatch match on UGEE. libwacom only provides this as a hint, if kwin prefers to display the kernel name then there's nothing you can do (in libwacom) to change that.

Is it alright that I omitted these comment lines or should I extend the .table file somehow?

Please extend it, e.g. all the Intuos tablets already in libwacom are external devices like the one you have. Until a few years ago, those were the majority before all the built-in ones started getting more numerous.

data/xp-pen-artist10s.tablet Outdated Show resolved Hide resolved
data/xp-pen-artist10s.tablet Outdated Show resolved Hide resolved
@hooger
Copy link
Contributor Author

hooger commented Jan 15, 2024

Please extend it, e.g. all the Intuos tablets already in libwacom are external devices like the one you have. Until a few years ago, those were the majority before all the built-in ones started getting more numerous.

I think I added all the necessary information in linuxwacom/wacom-hid-descriptors#354 Can you take a look again, please?

data/xp-pen-artist10s.tablet Outdated Show resolved Hide resolved
@whot whot merged commit 96e0f40 into linuxwacom:master Jan 22, 2024
12 of 13 checks passed
@whot
Copy link
Member

whot commented Jan 22, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants