-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding .tablet file for Ingenic touch and pen display. #621
Conversation
Hi, there. I'm a bot and have been asked to have a look at this. Please run the sysinfo script from https://github.com/linuxwacom/wacom-hid-descriptors and The
A See also https://github.com/linuxwacom/libwacom/wiki/Adding-a-new-device This is an automated comment created by a bot. Responding to the bot or mentioning it won't have any effect. |
I just fixed the sysinfo check in #623, can you please rebase on top of that? Thanks. |
bffbe48
to
d9194a3
Compare
Hi, there. I'm a bot and have been asked to have a look at this. Thanks for providing the sysinfo. Someone will be along shortly to review the PR. This is an automated comment created by a bot. Responding to the bot or mentioning it won't have any effect. |
hmm, looks like this fails The stylus tool ID is the |
I've checked into the ABS_MISC value via libinput record, and it appears to be something that determines distance of the pen from the display. It's incrementing by ~35 for each input "frame" and increases the increment value as the pen is pulled away from the screen.
Would the PenDisplay class fit this situation better? Also, if I'm not reading the libinput record reports right, please let me know. |
The
That sounds like maybe two separate things in the HID report are combined into one axis?
Yeah, let's try that, we can change it later if we end up with serial numbers. The |
Looking at the (too small) hid-recorders from https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/2727#note_1910892, isn't In other words, is |
@bentiss the delta between frames decreases as the pen tip gets closer to the screen. The actual value of ABS_MISC continues to increment until it hits FFFF, then it recycles. For completeness, here's a yaml of output from libinput record for the pen tip on the upper screen. Movement contents:
|
So in other words, this value always increments, no matter the position of the pen (it rolls over after reaching FFFF). And if you look at your recording, each ABS_MISC value is different from each other (minus the roll over), so this is a |
This is in reference to issue #602 . Adds support for the Ingenic touch/pen screens on the Lenovo Yoga Book 9i.
Edited 2Jan23 to correct laptop model name.