Correct w8001 issue / re-enable warnings #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: 6c7cc1a29d1e ("Input: wacom_w8001 - simplify device name generation")
Signed-off-by: Jason Gerecke <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Dmitry Torokhov <[email protected]>
[[email protected]: Imported into input-wacom (7ba38c2a9e1a)]
Signed-off-by: Jason Gerecke <[email protected]>
…stream warning" This reverts commit e83a9bb. We have fixed the w8001 driver to no longer trigger these warnings.
jigpu
requested review from
skomra,
Pinglinux,
Joshua-Dickens and
flying-elephant
|
LGTM. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The w8001 fix accepted upstream had an issue of its own that needed to be addressed. This pull request backports the required fix.
In addition, we revert the commit which disabled some warnings since the new code will not trigger warnings anymore.