Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flipper@connerdev] Fix dimming and a few other minor changes #755

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[Flipper@connerdev] Fix dimming and a few other minor changes #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Flipper@connerdev/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## 1.0.5

* Changed "dim_factor" to "opacity" since "dim_factor" is no longer defined
* Stop setting "brightness" since it's no longer defined
* Activate the new workspace on a change to avoid focus change errors
* Changed the "Include Background" option default to true

## 1.0.4

* Added a fix to make the animation performance better (smoother).
Expand Down
2 changes: 1 addition & 1 deletion Flipper@connerdev/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Flipper

Fancy workspace switching extension
Fancy workspace switching extension with 7 different effect options

Using the standard workspace switching hotkeys Ctrl+Alt+Left/Right will animate the workspace change with several types of animation effects (configurable in the extension settings)
10 changes: 6 additions & 4 deletions Flipper@connerdev/files/Flipper@connerdev/5.4/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ Flipper.prototype = {
this.last_direction = direction;

this.new_workspace = new_workspace;

new_workspace.activate(global.get_current_time());
this.prepare(from_workspace, to_workspace, direction, needScale);
},

Expand Down Expand Up @@ -928,7 +928,7 @@ Flipper.prototype = {

Tweener.addTween(from, {
x: -this.monitor.width,
brightness: 1.0,
//brightness: 1.0,
scale_x: this.getScale(),
scale_y: this.getScale(),
opacity: 0,
Expand Down Expand Up @@ -1381,7 +1381,8 @@ Flipper.prototype = {
this._backgroundGroup.show();
let background = this._backgroundGroup.get_children()[0];
Tweener.addTween(background, {
dim_factor: settings.dim_factor,
//dim_factor: settings.dim_factor,
opacity: Math.round(settings.dim_factor*255),
time: this.getTime(),
transition: 'easeInQuad'
});
Expand All @@ -1394,7 +1395,8 @@ Flipper.prototype = {
this._backgroundGroup.show();
let background = this._backgroundGroup.get_children()[0];
Tweener.addTween(background, {
dim_factor: 1.0,
//dim_factor: 1.0,
opacity: 255,
time: this.getTime(),
transition: 'easeInQuad',
onComplete: this.destroy,
Expand Down
2 changes: 1 addition & 1 deletion Flipper@connerdev/files/Flipper@connerdev/5.4/settings-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"includeBackground" : {
"type" : "checkbox",
"description" : "Include Background",
"default" : false
"default" : true
},
"includePanels" : {
"type" : "checkbox",
Expand Down
2 changes: 1 addition & 1 deletion Flipper@connerdev/files/Flipper@connerdev/metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"5.0",
"5.4"
],
"version": "1.0.4",
"version": "1.0.5",
"url": "https://github.com/ConnerHansen/Flipper",
"uuid": "Flipper@connerdev",
"name": "Flipper",
Expand Down