[[email protected]] Fix two bugs #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
klangman
commented
Sep 13, 2024
klangman
commented
- Fixed a bug in the disable() method where 'this' is not defined resulting in a failure to properly clean up after disabling the extension.
- Fixed the class register so that it uses a random number in the name to avoid a failure if the extension is re-enabled without a cinnamon restart.
1. Fixed a bug in the disable() method where 'this' is not defined resulting in a failure to properly clean up after disabling the extension. 2. Fixed the class register so that it uses a random number in the name to avoid a failure if the extension is re-enabled without a cinnamon restart.
|
@hermes83 These changes look OK to you? |
|
These are bug fixes and not a feature change. If you would like to apply a different fix, @hermes83 please feel free to do so. |
rcalixte
approved these changes
Sep 13, 2024
|
I'm using the extension with these merged fixes on the latest version of Mint and I don't see any problems, thanks @klangman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.