Various fixes, reliability improvements. #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add strict build warnings (disabled).
the backup locker. There's no reason to have two implementations - and the python version was completely based on this.
There's no gtk use here, so we can drop any dependency on it, and this is actually an inner loop from -pam-helper.
This ends up remaining active even after the screensaver unlocks.
activities. - Simplifies some startup/cancel/shutdown code that has remained even after some of behavior they were there for has been removed. - Merges a number of 'partial' refreshes for different events into a single path. - Cleans up unlock signals as soon as they're no longer required. They were keeping the unlock dialog around much longer than intended, and 'authenticate-cancel' was mixed up in the shutdown/ auth cancel sequence. - Eliminates overly-complicated interaction between the stage and unlock dialog during cancel and shutdown events. - Improves reliability during suspend and monitor change events.
the pam helper. Eliminate any query/response behavior when authentication is completed or cancelled. Previously authClient would tell the pam helper to exit, and wait for a response that it was doing so. Now, the pam helper will exit under two conditions: successful authentication will cause it to exit on its own (after sending the success message), or cancellation by the main process will send a SIGTERM to the helper, which will cause the helper to exit. In either case, the main process will never wait for a response or process end confirmation, making sure the UI is never hung up on this. The auth client will perform any resource cleanup asynchronously once the pam helper process actually exits. Simplify the pam-helper's life cycle.
attempting mouse and keyboard grabs. A frequent barrier to the screensaver starting is a modal window, application popup menu or cinnamon popup being left open when the user steps away from their computer. This will have the effect of cancelling or closing these if they exist. It sends two keystrokes in the event of a popup menu being raised by a modal dialog (the first will cancel the popup, the second the dialog). note: cinnamon popups could be addressed differently (expo/overview modes already are), but this wasn't possible with application popups. Ref: linuxmint#93
mtwebster
force-pushed
the
ss-auth-cleanup
branch
from
290092b
to
1eae39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to address reported reliability issues:
ref: #263, #392, #356, #406, #405, #383, #371, #359, #344, #343, #342, etc...
Note: I've never been able to reproduce any of these problems, but this reworks a number of aspects that were identified as suspect.