Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wayland上 chromeium112版本上传文件无法多选 #52

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Whale107
Copy link
Contributor

xdg-desktop-portal-dde 的 filechooser未给multiple字段赋值

Log: wayland上 chromeium112版本上传文件无法多选
Bug: https://pms.uniontech.com/bug-view-267187.html
Influence: 调出文馆对话框文件多选文件

xdg-desktop-portal-dde 的 filechooser未给multiple字段赋值

Log: wayland上 chromeium112版本上传文件无法多选
Bug: https://pms.uniontech.com/bug-view-267187.html
Influence: 调出文馆对话框文件多选文件
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • OpenFile函数中新增了对multiple选项的检查和处理,这可能是为了支持多选文件功能。

是否建议立即修改:

  • 否,当前提交的代码没有明显的语法错误或逻辑问题。
  • 是,建议添加对multiple选项的检查和处理,以确保代码的健壮性和功能正确性。
  • 是,建议添加单元测试来验证新增功能是否按预期工作,以避免未来的回归问题。

@justforlxz justforlxz merged commit 245b4e3 into linuxdeepin:master Aug 23, 2024
17 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justforlxz, Whale107

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants