Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add dde-portals.conf #39

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: add dde-portals.conf #39

merged 1 commit into from
Sep 20, 2023

Conversation

Decodetalkers
Copy link
Contributor

Log:

@Decodetalkers
Copy link
Contributor Author

linuxdeepin/developer-center#5681

@Decodetalkers Decodetalkers requested a review from a team September 18, 2023 07:22
BLumia
BLumia reviewed Sep 18, 2023
View reviewed changes
misc/dde-portals.conf Outdated
@@ -0,0 +1,2 @@
[preferred]
default=deepin
Copy link
Member

@BLumia BLumia Sep 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个值对应的是什么/哪里？表示的是 DDE 桌面环境还是 deepin 这个发行版？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/flatpak/xdg-desktop-portal/blob/main/doc/portals-conf.rst

portal的名称，这个conf确实是错了，名字和default反了

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flatpak/xdg-desktop-portal@main/doc/portals-conf.rst

portal的名称，这个conf确实是错了，名字和default反了

XDG_CURRENT_DESKTOP 小写也是 dde 把，文件名应该还是 dde-xxxx

Copy link
Contributor Author

@Decodetalkers Decodetalkers Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好吧,记错名字了，不过UserIn还不能删。新的确实刚发布，但是环境上的portal不是最新的，认的还不是conf

@Decodetalkers Decodetalkers force-pushed the addportalconf branch 2 times, most recently from 53ef20c to 436dcc4 Compare September 19, 2023 01:25
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, Decodetalkers, wineee

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Decodetalkers Decodetalkers merged commit 6525ad8 into linuxdeepin:master Sep 20, 2023
12 of 13 checks passed
@wineee wineee mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BLumia BLumia BLumia approved these changes

@wineee wineee wineee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Decodetalkers @deepin-ci-robot @BLumia @wineee