Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the call to the bash program #368

Merged

Conversation

wangrong1069
Copy link
Contributor

Remove the call to the bash program.

Log: enhance security
Task: https://pms.uniontech.com/task-view-362563.html

Remove the call to the bash program.

Log: enhance security
Task: https://pms.uniontech.com/task-view-362563.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 代码中使用了QStringList来存储分割后的字符串,但未考虑线程安全问题,如果多个线程同时处理result可能会导致数据不一致。
  • 在循环中直接使用result来修改result,这可能会导致逻辑错误,应该使用临时变量来存储修改后的值。
  • 代码中没有处理process.waitForStarted()process.waitForFinished()可能返回的错误信息,这可能会导致程序在未知错误下继续执行。
  • 代码中没有对process.start()的执行结果进行错误处理,如果命令执行失败,可能会导致程序崩溃。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, wangrong1069

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wangrong1069
Copy link
Contributor Author

/forcemerge

@deepin-bot deepin-bot bot merged commit 9b6d242 into linuxdeepin:release/105x Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants