Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: systemd monitor treeland adaptation #363

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

pengfeixx
Copy link
Contributor

systemd monitor treeland adaptation

Log: systemd monitor treeland adaptation

Copy link
Contributor

@rb-union rb-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@jeffshuai
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

systemd monitor treeland adaptation

Log: systemd monitor treeland adaptation
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • dmioem.c文件中新增的#include "lscpu.h"可能未在项目中使用,需确认是否有必要包含此头文件。
  • common.cpp中修改的代码逻辑判断增加了对isTreeLand()的检查,但没有提供isTreeLand()函数的实现细节,可能会导致编译错误或逻辑错误。
  • helper.hpp中的isTreeLand()函数使用了qEnvironmentVariable来检查环境变量,但没有考虑在某些情况下环境变量可能未设置的情况,可能会导致运行时错误。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lzwind, pengfeixx

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx merged commit 45aab9e into linuxdeepin:master Aug 20, 2024
8 of 9 checks passed
@pengfeixx pengfeixx deleted the treeland branch August 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants