Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 使用am启动deepin-system-monitor #359

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

fly602
Copy link

@fly602 fly602 commented Jul 29, 2024

使用am启动deepin-system-monitor
Issue: linuxdeepin/developer-center#9890 linuxdeepin/developer-center#9832

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • launchProcessByAM函数中,使用qCWarning而不是qWarning来记录日志,以便更好地区分错误和警告信息。
  • launchProcessByAM函数中的错误处理逻辑没有处理reply.errorName(),这可能会导致在错误处理时出现空指针异常。
  • launchProcessByAM函数中的return语句应该在qCWarning之后立即执行,而不是在QTimer::singleShot之后。
  • DBusServer::showDeepinSystemMoniter函数中的launchProcessByAM调用应该放在QTimer::singleShot的回调函数中,而不是直接在函数中调用。
  • DBusServer::showDeepinSystemMoniter函数中的launchProcessByAM调用应该使用launchProcessByAM函数本身作为回调函数,而不是使用[]()匿名函数。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fly602, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fly602
Copy link
Author

fly602 commented Jul 29, 2024

/merge

@deepin-bot deepin-bot bot merged commit 3526de5 into linuxdeepin:master Jul 29, 2024
9 checks passed
@jeffshuai
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants