Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing icon in DCC #358

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

zsien
Copy link
Member

@zsien zsien commented Jul 22, 2024

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 30, 2024

TAG Bot

New tag: 6.0.23
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #361

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在CMakeLists.txt中新增的INSTALL指令缺少注释说明其用途
  • 安装图标文件的路径使用了硬编码,建议使用变量或常量替代

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: max-lvs, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@max-lvs max-lvs merged commit 6710b33 into linuxdeepin:master Aug 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants