Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #341

Closed
Closed

Conversation

add-uos
Copy link
Contributor

@add-uos add-uos commented May 9, 2024

asd

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: add-uos

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • setRules函数中,使用了replace(";", "\n"),但是没有考虑到rules可能包含多个分号的情况,会导致日志信息不准确。
  • appendRules函数中,使用了split('\n')来分割字符串,但是没有考虑到字符串中可能包含多个换行符的情况,会导致分割结果不正确。
  • main函数中,使用了MLogger()来创建日志处理对象,但是在QTimer::singleShot中直接调用了MLogger的构造函数,这可能会导致在单线程环境中创建多个MLogger实例。

@add-uos add-uos closed this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants