Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can't pack v23 in obs #289

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Conversation

18202781743
Copy link
Contributor

@18202781743 18202781743 commented Sep 8, 2023

It intrudce in the commit 2b8ee33
Refact to distinguish the way of v20 and v23, we delay it
tu runtime step instead of compiling step.

Issue: https://pms.uniontech.com/bug-view-218813.html
Issue: linuxdeepin/developer-center#5562

@kegechen
Copy link

kegechen commented Sep 8, 2023

@wyu71

Copy link

@kegechen kegechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

  It intrudce in the commit 2b8ee33
  Refact to distinguish the way of v20 and v23, we delay it
tu runtime step instead of compiling step.
@jeffshuai
Copy link
Contributor

[是否满足兼容性要求] Y
[是否满足commit提交规范] Y
[是否满足编码规范] Y
[Review结论] Pass
[Fail原因] N/A

@18202781743
Copy link
Contributor Author

18202781743 commented Sep 8, 2023

@BLumia 帮忙审下,如果没问题帮忙合并下,我没权限,

Copy link
Contributor

@wyu71 wyu71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/+1

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, kegechen, wyu71

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit 6e1c14c into linuxdeepin:master Sep 8, 2023
5 checks passed
@18202781743
Copy link
Contributor Author

/integrate

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

AutoIntegrationPr Bot
auto integrate with pr url: deepin-community/Repository-Integration#478
PrNumber: 478
PrBranch: auto-integration-6120294651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants