Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add polkit support for root app #360

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Johnson-zs
Copy link
Contributor

add polkit support for root app

Log: add polkit support for root app

Bug: https://pms.uniontech.com/bug-view-273929.html

add polkit support for root app

Log: add polkit support for root app

Bug: https://pms.uniontech.com/bug-view-273929.html
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • isRootCaller函数中,使用connection().interface()->serviceUid(message().service()).value()来检查服务用户ID可能会导致安全问题,因为它允许任何服务调用该函数。建议使用更安全的检查方法。
  • DBusEnableInterface类的isRootCaller函数被声明为private,但仍然可以在类外部被访问和调用,这可能违反了封装原则。
  • DBusEnableInterface类的enableenablePrinter函数中使用了DriverDBusInterface::authority(),但没有检查这个函数是否可能返回无效或未定义的值。
  • modifyPath函数中使用了QRegExp("[1-9]$")来替换数字9,这可能不够健壮,如果路径中只有一个数字1,这个正则表达式将无法匹配。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Johnson-zs, lzwind

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Johnson-zs
Copy link
Contributor Author

/merge

@deepin-bot deepin-bot bot merged commit d412483 into linuxdeepin:release/105x Sep 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants