Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Read QLatin1String returned from QApt may be freed. #210

Merged
merged 1 commit into from
Jul 13, 2023
Merged

fix: Read QLatin1String returned from QApt may be freed. #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/deb-installer/manager/packagesmanager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ const ConflictResult PackagesManager::isConflictSatisfy(const QString &arch, Pac
const ConflictResult PackagesManager::isInstalledConflict(const QString &packageName, const QString &packageVersion,
const QString &packageArch)
{
static QList<QPair<QLatin1String, DependencyInfo>> sysConflicts;
static QList<QPair<QString, DependencyInfo>> sysConflicts;

if (sysConflicts.isEmpty()) {
Backend *backend = PackageAnalyzer::instance().backendPtr();
Expand All @@ -421,7 +421,9 @@ const ConflictResult PackagesManager::isInstalledConflict(const QString &package

for (const auto &conflict_list : conflicts)
for (const auto &conflict : conflict_list) {
sysConflicts << QPair<QLatin1String, DependencyInfo>(pkg->name(), conflict);
// FIXME: 在 Realse 模式下，某些场景后续调用 QLatin1String 时可能访问失败(内存被释放)!
// 临时修改为拷贝数据。
sysConflicts << QPair<QString, DependencyInfo>(pkg->name(), conflict);
}
pkg = nullptr;
}
Expand Down
Loading