Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gridView tab switched too quickly #408

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mhduiy
Copy link
Contributor

@mhduiy mhduiy commented Aug 23, 2024

Limit the interval between repeated clicks

Issue: linuxdeepin/developer-center#10481

Limit the interval between repeated clicks

Issue: linuxdeepin/developer-center#10481
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhduiy
Copy link
Contributor Author

mhduiy commented Aug 27, 2024

/test all

1 similar comment
@mhduiy
Copy link
Contributor Author

mhduiy commented Aug 27, 2024

/test all

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Keys.onPressed函数中,当按下左、右、上、下方向键时,没有检查当前索引是否有效,直接使用了gridView.count - 10来更新索引。这可能导致在按下左键时,索引变为-1,从而引发错误。
  • highlightMoveDuration属性从150毫秒减少到100毫秒,可能会影响用户界面的流畅度。
  • keyTimer的实现方式可能会导致在某些情况下无法正确处理按键事件,因为它在按下重复键时会跳过处理。
  • event.accepted = trueKeys.onPressed函数中被多次设置,这可能会导致事件处理逻辑出现问题。

是否建议立即修改:

@mhduiy mhduiy merged commit 7397779 into linuxdeepin:master Aug 27, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants