Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windowed mode folder animation incorrect start point #380

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Aug 5, 2024

多个问题导致:

  1. 文件夹的 20% 大小仍然比图标大,调到 10%
  2. 之前起点是 item 的左上角,应当以图标中心为起点
  3. 还需要将坐标进行一次映射

多个问题导致:

1. 文件夹的 20% 大小仍然比图标大,调到 10%
2. 之前起点是 item 的左上角,应当以图标中心为起点
3. 还需要将坐标进行一次映射

Log:
@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@BLumia BLumia marked this pull request as ready for review August 5, 2024 09:04
@BLumia BLumia requested a review from tsic404 August 5, 2024 09:04
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FreeSortListView.qml中,folderClicked函数的参数offset应该在调用mapToItem之前定义,以避免潜在的类型转换问题。
  • WindowedFrame.qml中的animationDuration属性被添加到了InputEventItem中,但动画的持续时间没有在InputEventItem的构造函数中使用,可能会导致动画效果不正确。
  • InputEventItem中的动画属性fromto的值在enterexit状态之间被重复使用,这可能不是预期的行为,应该考虑使用不同的值。
  • InputEventItem中的point属性在enterexit状态之间被重复使用,这可能不是预期的行为,应该考虑使用不同的值。
  • InputEventItem中的point属性在enterexit状态之间被重复使用,这可能不是预期的行为,应该考虑使用不同的值。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, tsic404

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit f94b923 into linuxdeepin:master Aug 5, 2024
9 of 10 checks passed
@BLumia BLumia deleted the windowed-animation-tweaks branch August 5, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants