Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: personalize fullscreen mode instead of windowed mode #379

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented Aug 5, 2024

应当对全屏模式进行处理,而非小窗口模式。

Log:

应当对全屏模式进行处理,而非小窗口模式。

Log:
@BLumia BLumia requested a review from justforlxz August 5, 2024 06:45
@deepin-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@BLumia BLumia marked this pull request as ready for review August 5, 2024 06:45
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 变量命名不一致:原代码中使用的是 "WindowedFrameApplicationWindow",而修改后的是 "FullscreenFrameApplicationWindow"。建议保持命名一致性,以避免混淆。
  • 缺少对新变量 fullscreenFrameWindow 的定义或初始化:在修改后的代码中,fullscreenFrameWindow 没有被定义和初始化,这可能会导致编译错误或运行时错误。
  • 缺少对新变量 fullscreenFrameWindow 的使用注释:虽然变量名已经表明了它的用途,但在实际代码中添加一些注释来解释为什么选择这个窗口对象可能是有帮助的。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, justforlxz

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit f782d5a into linuxdeepin:master Aug 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants