Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display issues with fullscreen frame #375

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

xionglinlin
Copy link
Contributor

When platform is xcb, set fixed size

Issue: linuxdeepin/developer-center#9996

@xionglinlin xionglinlin force-pushed the fix/9996 branch 2 times, most recently from 1d21886 to fc37088 Compare August 1, 2024 06:16
@xionglinlin
Copy link
Contributor Author

xionglinlin commented Aug 1, 2024

/review @BLumia @justforlxz @tsic404

BLumia
BLumia previously requested changes Aug 1, 2024
Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不应当由launchpad处理

@BLumia BLumia dismissed their stale review August 1, 2024 06:40

据讨论说是妥协做法

Copy link
Member

@BLumia BLumia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个地方反复加了删好多次了,我仍然不觉得应该改这里。如果沟通是妥协做法,请由参与沟通的人员来 approve。

关联:

@xionglinlin
Copy link
Contributor Author

/review @tsic404

@BLumia BLumia requested a review from tsic404 August 1, 2024 06:51
@deepin-bot
Copy link

deepin-bot bot commented Aug 1, 2024

TAG Bot

New tag: 0.8.2
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #374

@xionglinlin xionglinlin force-pushed the fix/9996 branch 2 times, most recently from 91635d1 to 3c6a535 Compare August 1, 2024 11:06
Remove the flags from the fullscreen frame as it affects the layershell set windowType

Issue: linuxdeepin/developer-center#9996
Issue: linuxdeepin/developer-center#9998
Issue: linuxdeepin/developer-center#9992
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • Component.onCompleted槽函数中,条件判断逻辑可能不正确。原代码中直接返回Qt.Window的情况已被DebugHelper.useRegularWindow的逻辑替代,但新代码中又试图通过if (DebugHelper.useRegularWindow)来设置flags,这可能不会按预期工作。
  • DLayerShellWindow.keyboardInteractivity的属性赋值被移除,但未提供替代逻辑或确认这一改动是否必要。
  • DWindow.enabled的逻辑依赖于DebugHelper.useRegularWindow,但当前的依赖关系不明确,需要更多上下文来判断这一改动是否正确。

是否建议立即修改:

  • 是,需要确认Component.onCompleted槽函数中的逻辑是否正确,并确保DWindow.enabled的逻辑不会影响现有功能。同时,需要提供更多上下文信息来理解DLayerShellWindow.keyboardInteractivity的改动。

@xionglinlin xionglinlin changed the title fix: fullscreen frame does not spread the full screen fix: display issues with fullscreen frame Aug 2, 2024
@xionglinlin xionglinlin requested a review from BLumia August 2, 2024 02:45
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, xionglinlin

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xionglinlin
Copy link
Contributor Author

/forcemerge

@deepin-bot
Copy link

deepin-bot bot commented Aug 2, 2024

This pr force merged! (status: blocked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants