-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement the logic for displaying launchpad positions on multi… #336
Conversation
qml/windowed/WindowedFrame.qml
Outdated
@@ -22,11 +22,6 @@ Item { | |||
|
|||
KeyNavigation.tab: appGridLoader.item | |||
|
|||
function getHorizontalCoordinatesOfSideBar() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
设计上需要dock的launcherItem与sideBar的中线对齐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
左右的没法跟sidebar对齐
这个我找设计先对下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已跟设计确认上下时保持原来对齐方式 左右时边线对齐
qml/Main.qml
Outdated
windowedFrameWindow.screen = dock.rootObject.screen | ||
fullscreenFrame.screen = dock.rootObject.screen | ||
} else { | ||
windowedFrameWindow.screen = Screen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的Screen是啥?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以不处理
已删除
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen这个附加属性,与Window.screen类型是匹配的,
只是这里的Screen设置跟它自己是相同的了,应该可以不用置,
074b211
to
fe4752f
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, robertkill The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ple screens. Implement the logic for displaying launchpad positions on multiple screens. Log:
deepin pr auto review关键摘要:
是否建议立即修改:
|
…ple screens.
Implement the logic for displaying launchpad positions on multiple screens.
Log: