feat: Implement the logic for displaying launchpad positions on multi… #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18202781743
reviewed
Jun 26, 2024
qml/windowed/WindowedFrame.qml
Outdated
| @@ -22,11 +22,6 @@ Item { | |||
|
|
|||
| KeyNavigation.tab: appGridLoader.item | |||
|
|
|||
| function getHorizontalCoordinatesOfSideBar() | |||
There was a problem hiding this comment.
设计上需要dock的launcherItem与sideBar的中线对齐
There was a problem hiding this comment.
左右的没法跟sidebar对齐
这个我找设计先对下
There was a problem hiding this comment.
已跟设计确认上下时保持原来对齐方式 左右时边线对齐
18202781743
reviewed
Jun 26, 2024
qml/Main.qml
Outdated
| windowedFrameWindow.screen = dock.rootObject.screen | ||
| fullscreenFrame.screen = dock.rootObject.screen | ||
| } else { | ||
| windowedFrameWindow.screen = Screen |
There was a problem hiding this comment.
Screen这个附加属性,与Window.screen类型是匹配的,
只是这里的Screen设置跟它自己是相同的了,应该可以不用置,
robertkill
force-pushed
the
master
branch
3 times, most recently
from
074b211
to
fe4752f
Compare
18202781743
approved these changes
Jun 26, 2024
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, robertkill The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ple screens. Implement the logic for displaying launchpad positions on multiple screens. Log:
deepin pr auto review关键摘要:
是否建议立即修改:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ple screens.
Implement the logic for displaying launchpad positions on multiple screens.
Log: