Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show full app name tooltips for truncated app name in windowed mode #302

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ArchieMeng
Copy link
Contributor

Issue: linuxdeepin/developer-center#8244
Log: Show full app name tooltips for truncated app name in windowed mode

Issue: linuxdeepin/developer-center#8244
Log: Show full app name tooltips for truncated app name in windowed mode
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • AppListView.qml中,ToolTip的显示条件增加了对contentItem.implicitWidthcontentItem.width的检查,这可能是为了确保当列表项的宽度变化时,提示信息能够正确显示。
  • FreeSortListView.qml中,ToolTip的显示条件增加了对hovered的检查,这可能是为了确保当鼠标悬停在列表项上时,提示信息能够正确显示。

是否建议立即修改:

  • 否,这些更改看起来是为了提高用户体验和代码的稳定性而做出的,但它们没有明显的错误。然而,建议进行以下几点检查和改进:
    • 确认ToolTip的显示条件是否符合预期的用户交互行为。
    • 检查是否有必要对contentItem.implicitWidthcontentItem.width进行比较,确保这种比较是必要的。
    • 考虑是否有必要对hovered状态进行检查,以确保不会因为意外的副作用而显示提示信息。
    • 如果这些更改是为了修复一个具体的问题,建议提供相关的上下文或测试用例来验证更改的正确性。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ArchieMeng, BLumia, kegechen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kegechen
Copy link
Contributor

kegechen commented Jun 4, 2024

/merge

@deepin-bot
Copy link

deepin-bot bot commented Jun 4, 2024

This pr cannot be merged! (status: blocked)

@kegechen kegechen merged commit a3a5908 into linuxdeepin:master Jun 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants