Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing border for FlolderPopup in windowed #283

Merged
merged 1 commit into from
May 15, 2024

Conversation

18202781743
Copy link
Contributor

@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FolderGridViewPopup.qml文件中,导入org.deepin.dtk.style 1.0 as DStyle可能是为了使用DStyle.Style.floatingPanel.outsideBorderDStyle.Style.floatingPanel.insideBorder这些样式属性。但是,这个改动可能会影响文件的兼容性,因为org.deepin.dtk.style库可能不是所有环境都能兼容的。
  • 引入新的样式依赖后,需要确认是否所有相关的平台都支持org.deepin.dtk.style库的引入。如果有的平台不支持,那么这个改动可能会导致样式问题。
  • 代码修改后的逻辑是,只有在窗口模式(isWindowedMode)下才使用DStyle.Style.floatingPanel.outsideBorderDStyle.Style.floatingPanel.insideBorder这些样式属性。这是一个合理的改动,但是需要确保isWindowedMode的逻辑正确实现,并且DStyle库中的Style.floatingPanel属性也确实存在这些样式属性。

是否建议立即修改:

  • 是,建议进行以下检查和改进:
    • 确认org.deepin.dtk.style库是否所有平台都兼容,如果不兼容,需要处理兼容性问题。
    • 检查isWindowedMode的实现是否正确,确保逻辑正确。
    • 如果DStyle.Style.floatingPanel.outsideBorderDStyle.Style.floatingPanel.insideBorder不存在,需要修改代码以使用其他样式或者添加相应的属性。
    • 添加注释说明为什么在窗口模式下才使用特定的样式,以便其他开发者理解这一改动的意图。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit e654bfe into linuxdeepin:master May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants