Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search result overflow #278

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

18202781743
Copy link
Contributor

add clip, and only doesn't clip it in FolderGridViewPopup.

add clip, and only doesn't clip it in FolderGridViewPopup.
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • FolderGridViewPopup.qml中新增了gridViewClip属性的默认值,但未提供修改的原因,可能会导致未预期的行为。
  • GridViewContainer.qml中,gridViewClip属性的默认值从false更改为true,需要确认这一改动是否符合预期的布局需求。
  • windowed/GridViewContainer.qml中,gridViewClip属性的默认值与GridViewContainer.qml保持一致,但应确保所有相关布局和行为都根据这一改动进行了调整。

合并相似的问题是否建议立即修改:

建议立即修改的原因是,这些改动可能会影响到布局和用户交互的行为,特别是当这些更改涉及到默认属性的变化时。需要确保这些改动是基于明确的业务逻辑需求,并且已经过充分的测试验证。如果这些更改是无意的或者没有经过充分讨论,可能会导致程序的行为不符合预期,影响用户体验。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@18202781743 18202781743 merged commit 60563f4 into linuxdeepin:master May 10, 2024
9 of 10 checks passed
@18202781743
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants