Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numpad quick search not working #275

Merged
merged 1 commit into from
May 10, 2024

Conversation

BLumia
Copy link
Member

@BLumia BLumia commented May 10, 2024

We should at least also check keypad modifier as well

Related: #269
Issue: linuxdeepin/developer-center#8495

We should at least also check keypad modifier as well

Related: linuxdeepin#269
Issue: linuxdeepin/developer-center#8495
@BLumia BLumia requested review from robertkill and a team May 10, 2024 03:29
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在FullscreenFrame.qml和WindowedFrame.qml文件中,对Keys.onPressed函数的修改可能会导致在某些情况下,用户在输入框中连续输入时可能会被截断,因为新的事件过滤器只允许一个字符。

合并相似的问题是否建议立即修改:

Syntax and logical errors:

  • 没有发现明显的语法或逻辑错误。

Code refactoring and quality:

  • 可以考虑将重复的代码逻辑提取成一个函数,以减少代码重复并提高可维护性。

Performance optimization:

  • 当前的修改可能不会对性能产生显著影响,但建议监控程序在实际使用中的表现,根据需要进行优化。

Security vulnerabilities:

  • 没有涉及到安全性的改动,但建议确保所有用户输入都经过适当的验证和清理,以防止潜在的安全风险。

Best practices:

  • 建议添加注释来解释为什么需要添加KeypadModifier到事件过滤器中,以便其他开发者理解这一变更的目的。
  • 确保代码遵循项目的编码规范,包括变量命名和代码格式化。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, BLumia

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia BLumia merged commit 8377c05 into linuxdeepin:master May 10, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants