Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot turn page by page turning indicator after the right mouse… #271

Merged

Conversation

yixinshark
Copy link
Contributor

@yixinshark yixinshark commented May 9, 2024

… clicked

cannot turn page by page turning indicator after the right mouse clicked。
adopt evasive method for Qt's bug:https://bugreports.qt.io/browse/QTBUG-125139

Log: fix cannot turn page by page turning indicator after the right mouse clicked
Issue: linuxdeepin/developer-center#8475
Influence: can turn page by page turning indicator after the right mouse

@yixinshark yixinshark force-pushed the fix-rightClickCannotTurnPage branch from c5ba32e to 01b1a2e Compare May 9, 2024 08:10
@yixinshark yixinshark requested a review from robertkill May 9, 2024 08:15
@yixinshark yixinshark force-pushed the fix-rightClickCannotTurnPage branch from 01b1a2e to fe4013d Compare May 9, 2024 08:20
@yixinshark yixinshark requested review from asterwyx and removed request for robertkill May 9, 2024 09:06
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: asterwyx, yixinshark

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

… clicked

cannot turn page by page turning indicator after the right mouse clicked
adopt evasive methods for Qt's bug:https://bugreports.qt.io/browse/QTBUG-125139

Log: fix cannot turn page by page turning indicator after the right mouse clicked
Issue: linuxdeepin/developer-center#8475
Influence: can turn page by page turning indicator after the right mouse
@yixinshark yixinshark force-pushed the fix-rightClickCannotTurnPage branch from fe4013d to 62b9fe5 Compare May 9, 2024 09:28
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • 在新增的鼠标区域中,直接修改了鼠标右键的默认行为,这可能会影响用户体验。
  • 添加了点击事件处理逻辑,用于阻止某些QtBUG-125139报告的bug。

是否建议立即修改:

Syntax and logical errors:

  • 无明显的语法或逻辑错误。

Code refactoring and quality:

  • 考虑是否有必要将鼠标区域的具体实现逻辑放在单独的控件中,以提高代码的可读性和可维护性。

Performance optimization:

  • 当前的修改不会对性能产生直接影响,但建议关注 larger issues in the codebase that could impact performance.

Security vulnerabilities:

  • 当前的修改不涉及安全性问题。

Best practices:

  • 建议在修改用户界面行为之前,与产品设计师沟通以确保用户体验符合预期。
  • 确保代码中有足够的注释来解释为什么需要阻止QtBUG-125139的行为,以及这个修改的预期效果是什么。

@yixinshark yixinshark merged commit d163d93 into linuxdeepin:master May 9, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants