console input, QoL #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konrad Dybcio <[email protected]>
not to be confused with 4chan memes Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
topic/features2
branch
from
98e0712
to
ce6bfbf
Compare
lumag
reviewed
May 7, 2024
lumag
reviewed
May 7, 2024
lumag
reviewed
May 7, 2024
These can apparently be handled too slow (because the stdin handler
thread takes its sweet time to spin up?), and receiving e.g. the
hello message ("Starting cdba server") and some warning (like
"cdba-server: Please switch to yaml config for ftdi_gpio configuration")
separated with a single LF char on the server side ends up with a
janky printout.
This is not ideal, but I suppose acking of the server status updates
could be introduced in a future update..
Signed-off-by: Konrad Dybcio <[email protected]>
stop the crossterm docs propaganda and flush stdout where ncessary Signed-off-by: Konrad Dybcio <[email protected]>
This could probably be generalized to all messages, but apart from this one, I think it would only make sense to also handle this for cases where the user pastes 1.5GiB of plaintext into MsgConsole, but then stdin is clogged up and there's no signals, so CTRL+A would wait for its turn anyway.. Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
topic/features2
branch
from
ce6bfbf
to
a3a461f
Compare
Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
topic/features2
branch
from
a3a461f
to
9459eda
Compare
lumag
approved these changes
May 21, 2024
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
konradybcio
force-pushed
the
topic/features2
branch
from
acdaf40
to
6619020
Compare
lumag
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.