Merge pull request #69 from lino-levan/feat-infer-type-in-evaluate

feat: infer return type in evaluate
lino-levan · May 23, 2024 · bf36cf6 · bf36cf6
2 parents 051780d + 786959d
commit bf36cf6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/page.ts b/src/page.ts
@@ -440,7 +440,7 @@ export class Page extends EventTarget {
   async evaluate<T, R extends AnyArray>(
     func: EvaluateFunction<T, R>,
     evaluateOptions?: EvaluateOptions<R>,
-  ): Promise<unknown> {
+  ): Promise<T> {
     if (typeof func === "function") {
       const args = evaluateOptions?.args ?? [];
       func = `(${func.toString()})(${
@@ -461,11 +461,14 @@ export class Page extends EventTarget {
     }
 
     if (result.type === "bigint") {
+      // @ts-ignore Only returns this value if T does
       return BigInt(result.unserializableValue!.slice(0, -1));
     } else if (result.type === "undefined") {
+      // @ts-ignore Only returns this value if T does
       return undefined;
     } else if (result.type === "object") {
       if (result.subtype === "null") {
+        // @ts-ignore Only returns this value if T does
         return null;
       }
     }