Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add kdp extension app by kubeSphere #179

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Feat: add kdp extension app by kubeSphere #179

wants to merge 14 commits into from

Conversation

harlee-x
Copy link
Collaborator

Description of your changes

Fixes # add kdp extension app by kubeSphere

How has this code been tested

@harlee-x harlee-x requested a review from jason-ltc July 22, 2024 09:33
@harlee-x harlee-x self-assigned this Jul 22, 2024
@harlee-x harlee-x changed the title Feat#add kdp extension app by kubeSphere Feat: add kdp extension app by kubeSphere Jul 22, 2024
@harlee-x
fix: change docker push
2c1dd07 
Signed-off-by: harlee-x <[email protected]>
jason-ltc
jason-ltc requested changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@jason-ltc jason-ltc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI should build both common chart and KS package, so the structure should be:

- Dockerfile
- docker
  |- hooks
- helm
  |- charts
    | - kdp
    | - web
  | - static

@harlee-x harlee-x force-pushed the feat#add_infra_chart branch 4 times, most recently from 3f16b6a to abe3aa2 Compare July 26, 2024 09:20
@harlee-x harlee-x requested a review from jason-ltc July 26, 2024 09:21
@harlee-x harlee-x force-pushed the feat#add_infra_chart branch 3 times, most recently from 895a19c to 33d98f3 Compare July 29, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-ltc jason-ltc Awaiting requested review from jason-ltc

Requested changes must be addressed to merge this pull request.

Assignees

@harlee-x harlee-x

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harlee-x @jason-ltc