Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linkerd mc link's output compatible with pre-edge-24.9.3 clusters #13161

Merged
merged 2 commits into from
Oct 10, 2024

Commits on Oct 9, 2024

  1. Make linkerd mc link's output compatible with pre-edge-24.9.3 clusters

    Followup to #1306
    
    ## Problem
    
    if we run `linkerd mc link` using the latest CLI and attempted to apply the resulting manifests into a cluster with linkerd-multicluster on version edge-24.9.2 and earlier we would get the following error:
    
    ```
    Error from server (BadRequest): error when creating "STDIN": Link in version "v1alpha1" cannot be handled as a Link: strict decoding error: unknown field "spec.probeSpec.failureThreshold", unknown field "spec.probeSpec.timeout"
    ```
    
    ## Solution
    
    This changes the `linkerd mc link` command so that it doesn't generate default entries for the new (optional) fields `failureThreshold` and `timeout`, so that the output remains compatible with previous versions of the Link CRD.
    
    `linkerd mc link` will however still generate those fields for clusters that have an up-to-date multicluster extension. Those fields values continue to be retrieved from the gateway service's `mirror.linkerd.io/probe-failure-threshold` and `mirror.linkerd.io/probe-timeout` annotations.
    
    Note that once the linkerd-multicluster extension gets upgraded in the cluster to match the CLI version, the existing Link CRs will automatically receive the default values for these fields.
    alpeb committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    d05e870 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Remove the new fields from the linkerd-multicluster chart, and the co…

    …rresponding annotations from the gateway workload
    alpeb committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    14e3829 View commit details
    Browse the repository at this point in the history