Add remote-discovery service mirroring #11201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Leong <[email protected]>
Signed-off-by: Alex Leong <[email protected]>
alpeb
approved these changes
Aug 4, 2023
| } | ||
|
|
||
| func (rcsw *RemoteClusterServiceWatcher) isRemoteDiscovery(svc *corev1.Service) bool { | ||
| // Treat an empty remoteDisocverySelector as "Nothing" instead of |
There was a problem hiding this comment.
Suggested change
| // Treat an empty remoteDisocverySelector as "Nothing" instead of | |
| // Treat an empty remoteDiscoverySelector as "Nothing" instead of |
mateiidavid
reviewed
Aug 8, 2023
There was a problem hiding this comment.
Looks great! I tested this out locally and it works as expected, no endpoints are created and the correct labels are added:
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"v1","kind":"Service","metadata":{"annotations":{"service.kubernetes.io/topology-aware-hints":"auto"},"labels":{"mirror.linkerd.io/exported":"true"},"name":"podinfo","namespace":"default"},"spec":{"ports":[{"port":80,"targetPort":9898}],"selector":{"app":"podinfo"},"type":"ClusterIP"}}
mirror.linkerd.io/remote-resource-version: "1510"
mirror.linkerd.io/remote-svc-fq-name: podinfo.default.svc.cluster.local
service.kubernetes.io/topology-aware-hints: auto
creationTimestamp: "2023-08-08T13:02:27Z"
labels:
mirror.linkerd.io/cluster-name: target
mirror.linkerd.io/mirrored-service: "true"
multicluster.linkerd.io/remote-discovery: target
multicluster.linkerd.io/remote-service: podinfoOne small nit. Should we make it so that service.kubernetes.io/topology-aware-hints is not copied over? We mentioned that a few times when talking about the service mirror's role in multicluster.
mateiidavid
reviewed
Aug 8, 2023
mateiidavid
approved these changes
Aug 8, 2023
adleong
added a commit
that referenced
this pull request
Aug 9, 2023
This is a follow-up to #11201, addressing some feedback from that PR. * fixes a typo in a comment * do not copy the topology aware hints (TAH) annotation onto mirror service, becuase TAH is not multicluster aware. Signed-off-by: Alex Leong <[email protected]>
hawkw
added a commit
that referenced
this pull request
Aug 11, 2023
## edge-23.8.2 This edge release adds improvements to Linkerd's multi-cluster features as part of the [flat network support] planned for Linkerd stable-2.14.0. In addition, it fixes an issue ([#10764]) where warnings about an invalid metric were logged frequently by the Destination controller. * Added a new `remoteDiscoverySelector` field to the multicluster `Link` CRD, which enables a service mirroring mod where the control plane performs discovery for the mirrored service from the remote cluster, rather than creating Endpoints for the mirrored service in the source cluster ([#11190], [#11201], [#11220], and [#11224]) * Fixed missing "Services" menu item in the Spanish localization for the `linkerd-viz` web dashboard ([#11229]) (thanks @mclavel!) * Replaced `server_port_subscribers` Destination controller gauge metric with `server_port_subscribes` and `server_port_unsubscribes` counter metrics ([#11206]; fixes [#10764]) * Replaced deprecated `failure-domain.beta.kubernetes.io` labels in Helm charts with `topology.kubernetes.io` labels ([#11148]; fixes [#11114]) (thanks @piyushsingariya!) [#10764]: #10764 [#11114]: #11114 [#11148]: #11148 [#11190]: #11190 [#11201]: #11201 [#11206]: #11206 [#11220]: #11220 [#11224]: #11224 [#11229]: #11229 [flat network support]: https://linkerd.io/2023/07/20/enterprise-multi-cluster-at-scale-supporting-flat-networks-in-linkerd/
Merged
hawkw
added a commit
that referenced
this pull request
Aug 11, 2023
## edge-23.8.2 This edge release adds improvements to Linkerd's multi-cluster features as part of the [flat network support] planned for Linkerd stable-2.14.0. In addition, it fixes an issue ([#10764]) where warnings about an invalid metric were logged frequently by the Destination controller. * Added a new `remoteDiscoverySelector` field to the multicluster `Link` CRD, which enables a service mirroring mode where the control plane performs discovery for the mirrored service from the remote cluster, rather than creating Endpoints for the mirrored service in the source cluster ([#11190], [#11201], [#11220], and [#11224]) * Fixed missing "Services" menu item in the Spanish localization for the `linkerd-viz` web dashboard ([#11229]) (thanks @mclavel!) * Replaced `server_port_subscribers` Destination controller gauge metric with `server_port_subscribes` and `server_port_unsubscribes` counter metrics ([#11206]; fixes [#10764]) * Replaced deprecated `failure-domain.beta.kubernetes.io` labels in Helm charts with `topology.kubernetes.io` labels ([#11148]; fixes [#11114]) (thanks @piyushsingariya!) [#10764]: #10764 [#11114]: #11114 [#11148]: #11148 [#11190]: #11190 [#11201]: #11201 [#11206]: #11206 [#11220]: #11220 [#11224]: #11224 [#11229]: #11229 [flat network support]: https://linkerd.io/2023/07/20/enterprise-multi-cluster-at-scale-supporting-flat-networks-in-linkerd/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add the ability to mirror services in "remote discovery" mode where no Endpoints are created for the service in the source cluster, but instead the
multicluster.linkerd.io/remote-discoveryandmulticluster.linkerd.io/remote-servicelabels are set on the mirror service to indicate that the control plane should perform remote discovery for this service.To accomplish this, we add a new field to the Link resource:
remoteDiscoverySelectorwhich is a parallel toselectorbut instead it selects Services to export in remote discovery mode. Since this field is purely additive, we do not change the Link CRD version. By treating an empty selector as "Nothing", we remain backwards compatible (an unsetremoteDiscoverySelectorwill not export any services in remote discovery mode).