Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linkerd check --output flag description #11145

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Fix linkerd check --output flag description #11145

merged 1 commit into from
Jul 24, 2023

Conversation

siggy
Copy link
Member

@siggy siggy commented Jul 21, 2023

The linkerd check --output flag supports 3 formats: table, json, and short. The default linkerd check command description incorrectly printed basic, json, short. Other extension check commands printed basic, json.

Modify all check output descriptions to print table, json, short.

The `linkerd check --output` flag supports 3 formats: `table`, `json`,
and `short`. The default `linkerd check` command description incorrectly
printed `basic, json, short`. Other extension check commands printed
`basic, json`.

Modify all check output descriptions to print `table, json, short`.

Signed-off-by: Andrew Seigner <[email protected]>
@siggy siggy requested a review from a team as a code owner July 21, 2023 14:57
Copy link
Member

@mateiidavid mateiidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great.

@adleong adleong merged commit 042c566 into linkerd:main Jul 24, 2023
36 checks passed
@hawkw hawkw added this to the stable-2.13.6 milestone Aug 8, 2023
hawkw pushed a commit that referenced this pull request Aug 9, 2023
The `linkerd check --output` flag supports 3 formats: `table`, `json`,
and `short`. The default `linkerd check` command description incorrectly
printed `basic, json, short`. Other extension check commands printed
`basic, json`.

Modify all check output descriptions to print `table, json, short`.

Signed-off-by: Andrew Seigner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants