feat(app): Add hostname label to http metrics #733
cratelynpr.yml
on: pull_request
Annotations
4 errors
|
rust:
linkerd/app/outbound/src/http/logical/policy/route/metrics/tests.rs#L104
error: constants have by default a `'static` lifetime
--> linkerd/app/outbound/src/http/logical/policy/route/metrics/tests.rs:104:20
|
104 | const HOST_1: &'static str = "great.website";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `-D clippy::redundant-static-lifetimes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::redundant_static_lifetimes)]`
|
|
rust:
linkerd/app/outbound/src/http/logical/policy/route/metrics/tests.rs#L107
error: constants have by default a `'static` lifetime
--> linkerd/app/outbound/src/http/logical/policy/route/metrics/tests.rs:107:20
|
107 | const HOST_2: &'static str = "different.website";
| -^^^^^^^---- help: consider removing `'static`: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
|
|
rust
Process completed with exit code 1.
|
|
ship-it
Process completed with exit code 1.
|