Skip to content

feat(app): Add hostname label to http metrics #726

feat(app): Add hostname label to http metrics

feat(app): Add hostname label to http metrics #726

Triggered via pull request October 9, 2024 05:01
Status Failure
Total duration 5m 55s
Artifacts

pr.yml

on: pull_request
Matrix: rust-crates
ship-it
4s
ship-it
Fit to window
Zoom out
Zoom in

Annotations

6 errors
rust: linkerd/app/outbound/src/http/logical/policy/route.rs#L136
error: returning the result of a `let` binding from a block --> linkerd/app/outbound/src/http/logical/policy/route.rs:137:21 | 136 | let layer = retry::NewHttpRetry::layer_via_mk(mk_extract, metrics); | ------------------------------------------------------------------- unnecessary `let` binding 137 | layer | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 136 ~ 137 ~ retry::NewHttpRetry::layer_via_mk(mk_extract, metrics) |
rust: linkerd/app/outbound/src/http/logical/policy/route.rs#L137
error: returning the result of a `let` binding from a block --> linkerd/app/outbound/src/http/logical/policy/route.rs:137:21 | 136 | let layer = retry::NewHttpRetry::layer_via_mk(mk_extract, metrics); | ------------------------------------------------------------------- unnecessary `let` binding 137 | layer | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 136 ~ 137 ~ retry::NewHttpRetry::layer_via_mk(mk_extract, metrics) |
rust: linkerd/app/outbound/src/http/logical/policy/route.rs#L136
error: returning the result of a `let` binding from a block --> linkerd/app/outbound/src/http/logical/policy/route.rs:137:21 | 136 | let layer = retry::NewHttpRetry::layer_via_mk(mk_extract, metrics); | ------------------------------------------------------------------- unnecessary `let` binding 137 | layer | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 136 ~ 137 ~ retry::NewHttpRetry::layer_via_mk(mk_extract, metrics) |
rust: linkerd/app/outbound/src/http/logical/policy/route.rs#L137
error: returning the result of a `let` binding from a block --> linkerd/app/outbound/src/http/logical/policy/route.rs:137:21 | 136 | let layer = retry::NewHttpRetry::layer_via_mk(mk_extract, metrics); | ------------------------------------------------------------------- unnecessary `let` binding 137 | layer | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `-D clippy::let-and-return` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::let_and_return)]` help: return the expression directly | 136 ~ 137 ~ retry::NewHttpRetry::layer_via_mk(mk_extract, metrics) |
rust
Process completed with exit code 1.
ship-it
Process completed with exit code 1.