feat: experimental support for GRPCRoute resource
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
3 times, most recently
from
ebd092c
to
18dccea
Compare
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
from
73af013
to
7f7fd3e
Compare
3 tasks
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
from
49065d7
to
1fa85cb
Compare
3 tasks
olix0r
reviewed
Apr 29, 2024
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
3 times, most recently
from
c2ef584
to
6d469f4
Compare
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
from
6d469f4
to
6329611
Compare
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
from
6329611
to
e9e61e9
Compare
Signed-off-by: Mark S <[email protected]>
the-wondersmith
force-pushed
the
feat-grpcroute-support
branch
from
e9e61e9
to
188cf14
Compare
adleong
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds support for the experimental
GRPCRouteresource [ref].PR takes special care to ensure
GrpcRouteand its associated types match the style and convention of the existingHttpRoutetype, and reuses the applicableHttpRoutetypes as notated in GEP-1016 to facilitate downstream utility as much as possible.