Disable bloom filter and improve benchmark code.

linkedfactory · Jul 29, 2024 · 735e86b · 735e86b
1 parent 9e5e102
commit 735e86b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/...dfactory.core/src/main/java/io/github/linkedfactory/core/kvin/parquet/ParquetHelpers.java b/...dfactory.core/src/main/java/io/github/linkedfactory/core/kvin/parquet/ParquetHelpers.java
@@ -76,7 +76,7 @@ static ParquetWriter<KvinTupleInternal> getParquetDataWriter(Path dataFile) thro
 				.withPageSize(PAGE_SIZE)
 				.withDictionaryPageSize(DICT_PAGE_SIZE)
 				.withDataModel(reflectData)
-				.withBloomFilterEnabled("id", true)
+				//.withBloomFilterEnabled("id", true)
 				.build();
 	}
 
@@ -90,7 +90,7 @@ static ParquetWriter<Object> getParquetMappingWriter(Path dataFile) throws IOExc
 				.withRowGroupSize(ROW_GROUP_SIZE_MAPPINGS)
 				.withPageSize(PAGE_SIZE)
 				.withDictionaryPageSize(DICT_PAGE_SIZE)
-				.withBloomFilterEnabled("value", true)
+				//.withBloomFilterEnabled("value", true)
 				.withDataModel(reflectData)
 				.build();
 	}

diff --git a/...c/test/java/io/github/linkedfactory/core/kvin/parquet/benchmark/KvinParquetBenchmark.java b/...c/test/java/io/github/linkedfactory/core/kvin/parquet/benchmark/KvinParquetBenchmark.java
@@ -38,8 +38,8 @@
 
 @State(Scope.Benchmark)
 @Fork(value = 1, jvmArgs = {"-Dorg.slf4j.simpleLogger.defaultLogLevel=warn", "-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=1044"})
-@Warmup(iterations = 3, time = 500, timeUnit = TimeUnit.MILLISECONDS)
-@Measurement(iterations = 3, time = 500, timeUnit = TimeUnit.MILLISECONDS)
+@Warmup(iterations = 3, time = 5000, timeUnit = TimeUnit.MILLISECONDS)
+@Measurement(iterations = 3, time = 5000, timeUnit = TimeUnit.MILLISECONDS)
 @BenchmarkMode(Mode.AverageTime)
 @OutputTimeUnit(TimeUnit.MILLISECONDS)
 public class KvinParquetBenchmark {
@@ -97,7 +97,7 @@ public KvinParquetBenchmark() {
 
     public static void main(String[] args) throws RunnerException {
         Options opt = new OptionsBuilder()
-                .include(KvinParquetBenchmark.class.getSimpleName() + ".testKvinParquetReadPerformanceForProcessUseCase") // adapt to control which benchmark tests to run
+                .include(KvinParquetBenchmark.class.getSimpleName()) // adapt to control which benchmark tests to run
                 .forks(1)
                 .build();