Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elided_lifetimes_in_path in Xilem Core #740

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Nov 12, 2024

No description provided.

Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standard lint compliance.

@DJMcNab
Copy link
Member Author

DJMcNab commented Nov 12, 2024

There has been some discussion on Zulip. https://xi.zulipchat.com/#narrow/channel/419691-linebender/topic/Standard.20Lint.20set/near/481912214

Essentially, the only conclusion we can really reach is that the tooling here is really bad. If tooling improved to allow enforcing a different set of choices (e.g. with a per-type attribute), I'd be all for swapping this back again. However, currently the only way to get consistency is to go with what Rust will enforce.

@DJMcNab DJMcNab added this pull request to the merge queue Nov 12, 2024
Merged via the queue into linebender:main with commit 751bd62 Nov 12, 2024
17 checks passed
@DJMcNab DJMcNab deleted the elided_lifetimes_in_core branch November 12, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants