Propagate the stashed
state correctly
#613
Open
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently errors with
ERROR layout: Error in 'ScrollBar' #385: trying to compute layout of stashed widget.
if more items are added so a scrollbar becomes visible when it wasn't previously (e.g. into_do_list
).@PoignardAzur would you be willing to take over digging into this - this happens because
is_stashed
doesn't get immediately reset upon callingset_stashed
, due to the stashed pass. However,Portal
wants to require that this is immediately set.This is discussed in #masonry>
to_do_list
: Horrendous performance