Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect to tracy if the tracy feature is enabled #612

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

DJMcNab
Copy link
Member

@DJMcNab DJMcNab commented Sep 24, 2024

This is very useful for debugging performance issues. I've already used it to debug #masonry>to_do_list: Horrendous performance.

Setting a feature works on a workspace-wide basis. I.e cargo run --example mason --features tracy works.

Some weirdness:

  • Tracy seems to assume we know when a frame will "start", but we only know if we'll repaint once processing for an event has finished.
  • Something seems to be starting a default "Frame", which isn't really right. We don't have any continuous frames. Maybe we should always request a redraw if tracy is enabled.

Either way, I think this feature is useful to land now, so am not planning on resolving these in this PR unless someone provides a solution.

Copy link
Contributor

@PoignardAzur PoignardAzur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code isn't too clear if you don't know wgpu_profiler or tracy, but it's mostly plumbing anyway.

I would like a short comment in the code (not just the Cargo manifest) explaining what tracy is, and giving a short explanation of how to use it.

Ideally we should have a full "How to debug Masonry perf problems" tutorial somewhere in our documentation, but that's a future item.

@DJMcNab DJMcNab added this pull request to the merge queue Oct 2, 2024
@DJMcNab DJMcNab removed this pull request from the merge queue due to a manual request Oct 2, 2024
@DJMcNab DJMcNab enabled auto-merge October 2, 2024 12:45
@DJMcNab DJMcNab added this pull request to the merge queue Oct 2, 2024
Merged via the queue into linebender:main with commit 1fe790a Oct 2, 2024
17 checks passed
@DJMcNab DJMcNab deleted the tracy branch October 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants